Improve join order for RangeAnalysis::boundedPhi#8393
Closed
smowton wants to merge 3 commits into
Closed
Conversation
hvitved
reviewed
Mar 10, 2022
| Reason reason | ||
| ) { | ||
| forex(SsaVariable inp, SsaReadPositionPhiInputEdge edge | edge.phiInput(phi, inp) | | ||
| // Forcibly split into an existence and a forall stage instead of using forex because otherwise |
Contributor
There was a problem hiding this comment.
I am surprised to see that this doesn't use the "ranking approach" as in e.g. the modulus library. Replacing recursion through forall/forex with recursion over ranked indices typically performs much better.
Contributor
There was a problem hiding this comment.
Yes. I prefer that PR over this one.
Contributor
There was a problem hiding this comment.
(this one also appears to have a significant slow-down on palatable/lambda).
Contributor
Author
|
Dropped in favour of #8405 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.